From fd95223d9703b9c038ed3c782474c885052dda08 Mon Sep 17 00:00:00 2001 From: futian.liu <liufutianyoo@163.com> Date: 星期五, 22 十二月 2023 17:05:25 +0800 Subject: [PATCH] 代码整理 --- consum-base/src/main/java/com/consum/base/service/impl/BaseGoodsModelsServiceImpl.java | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/consum-base/src/main/java/com/consum/base/service/impl/BaseGoodsModelsServiceImpl.java b/consum-base/src/main/java/com/consum/base/service/impl/BaseGoodsModelsServiceImpl.java index f83629a..b118221 100644 --- a/consum-base/src/main/java/com/consum/base/service/impl/BaseGoodsModelsServiceImpl.java +++ b/consum-base/src/main/java/com/consum/base/service/impl/BaseGoodsModelsServiceImpl.java @@ -1,5 +1,6 @@ package com.consum.base.service.impl; +import java.util.Collections; import java.util.HashMap; import java.util.List; import java.util.Map; @@ -110,7 +111,7 @@ public List<BaseGoodsModels> selectByModelsIdList(List<Long> idList) { if (CollectionUtils.isEmpty(idList)) { log.error("鍙傛暟閿欒"); - return null; + return Collections.emptyList(); } StringBuilder sql = new StringBuilder("SELECT * FROM base_goods_models WHERE 1 = 1 "); HashMap<String, Object> paramts = new HashMap<>(); @@ -127,9 +128,6 @@ return this.select(sql.toString(), paramts, new BaseGoodsModels()); } - private String QUERY_GOODS_MODEL_INFO = - "SELECT CLASSIFICATION type, goodsTemp.CATEGORY_ID,goodsTemp.CATEGORY_NAME,goodsTemp.id goods_Id,goodsTemp.GOODS_NAME,model.MODEL_NAME,model.id base_Goods_Models_Id,model.UNIT FROM BASE_GOODS_MODELS model LEFT JOIN BASE_GOODS_TEMPLATE goodsTemp ON model.GOODS_TEMPLATES_ID=goodsTemp.id"; - /** * 鏍规嵁鐗╁搧鍨嬪彿id 鏌ヨ鐗╁搧淇℃伅 * @@ -138,7 +136,10 @@ */ @Override public List<Map<String, Object>> queryGoodsModelInfo(Long baseGoodsModelsId) { - StringBuilder sql = new StringBuilder(QUERY_GOODS_MODEL_INFO); + StringBuilder sql = new StringBuilder( + "SELECT CLASSIFICATION type, goodsTemp.CATEGORY_ID,goodsTemp.CATEGORY_NAME,goodsTemp.id goods_Id," + + "goodsTemp.GOODS_NAME,model.MODEL_NAME,model.id base_Goods_Models_Id,model.UNIT " + + "FROM BASE_GOODS_MODELS model LEFT JOIN BASE_GOODS_TEMPLATE goodsTemp ON model.GOODS_TEMPLATES_ID=goodsTemp.id "); HashMap<String, Object> paramts = new HashMap<>(); sql.append(" where model.id=:baseGoodsModelsId"); paramts.put("baseGoodsModelsId", baseGoodsModelsId); -- Gitblit v1.9.1